settings: made monitors selectable in fullscreen modes #17648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teinarss
previously requested changes
Feb 5, 2020
pchote
reviewed
Feb 5, 2020
pchote
reviewed
Feb 6, 2020
|
It looks like you maybe forgot to push the latest fixes? |
|
Sorry, I was just hesitant because i forgot to test tiberian dawn, which has a different settings.yaml. |
pchote
reviewed
Feb 7, 2020
everclear72216
force-pushed
the
feature/make-monitos-selectable-in-fullscreen-modes
branch
from
64509b6
to
e086661
Compare
|
Took care of the comments and squashed the commits. Reworded commit message. |
|
Tested on Ubuntu, works as promised 👍 I'm just wondering whether the display dropdown should be visible on single monitor setups as it serves no purpose in that case 🤔 |
|
We should still show it (otherwise it makes the UI code even more of a nightmare), but should disable the dropdown so its not clickable. |
pchote
reviewed
Feb 8, 2020
everclear72216
force-pushed
the
feature/make-monitos-selectable-in-fullscreen-modes
branch
from
e086661
to
f02068b
Compare
pchote
approved these changes
Feb 8, 2020
everclear72216
deleted the
feature/make-monitos-selectable-in-fullscreen-modes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An integer value has been added to the graphics settings and is
pushed though the Platform interface to the Sdl2PlatformWindow.
The integer represents the display index used by SDL to identify
a display device.
The platform window hinterface has been extended to provide a
method which can be used to retrieve the available monitors.
The renderer class has been extended to give access to this
information within the settings logic class.
In the display tab of the settings menu the monitor can be
selected via a dropdown iff a non-windowed mode is selected.
"restart necessary"-logic has been updated to cater for the new
configuration option which can only be applied after restart.
The UI has been adaptet for mods/common and mods/cnc
closes #12363
Thank you for your contribution to OpenRA!
Please be aware that we do not have enough project maintainers to match the rate of contributions, so it may take several days before somebody is able to respond to your Pull Request.
You can help speed up the review process by following a few steps:
make testandmake checkcommands to check for (and fix!) any issues that are reported by our automated tests.If you need any help you can ask in the #openra IRC channel on freenode (most active during European evenings).